From 2a69482adb5a0100be3b0dc2ce1ffebf8e78165e Mon Sep 17 00:00:00 2001 From: yyc12345 Date: Sun, 5 Jul 2026 09:05:58 +0800 Subject: [PATCH] fix: change default settings - change default settings to make the default behavior more close to legacy Windows Photo Viewer. - remove redundant fallback for fetching enum settings. --- app/settings.cpp | 18 +++++++----------- app/settings.h | 1 + 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/app/settings.cpp b/app/settings.cpp index 81165c0..1b90c44 100644 --- a/app/settings.cpp +++ b/app/settings.cpp @@ -17,7 +17,7 @@ Settings *Settings::instance() { // SAFETY: // This is a global singleton and it is leaked by design. - static Settings* INSTANCE = new Settings(); + static Settings* INSTANCE = new Settings(nullptr); return INSTANCE; } @@ -67,29 +67,25 @@ bool Settings::svgTiny12Only() const Settings::DoubleClickBehavior Settings::doubleClickBehavior() const { - QString result = m_qsettings->value("double_click_behavior", "Close").toString(); - - return QEnumHelper::fromString(result, DoubleClickBehavior::Close); + QString result = m_qsettings->value("double_click_behavior", "").toString(); + return QEnumHelper::fromString(result, DoubleClickBehavior::Ignore); } Settings::MouseWheelBehavior Settings::mouseWheelBehavior() const { - QString result = m_qsettings->value("mouse_wheel_behavior", "Zoom").toString(); - + QString result = m_qsettings->value("mouse_wheel_behavior", "").toString(); return QEnumHelper::fromString(result, MouseWheelBehavior::Zoom); } Settings::WindowSizeBehavior Settings::initWindowSizeBehavior() const { - QString result = m_qsettings->value("init_window_size_behavior", "Auto").toString(); - - return QEnumHelper::fromString(result, WindowSizeBehavior::Auto); + QString result = m_qsettings->value("init_window_size_behavior", "").toString(); + return QEnumHelper::fromString(result, WindowSizeBehavior::Maximized); } Qt::HighDpiScaleFactorRoundingPolicy Settings::hiDpiScaleFactorBehavior() const { - QString result = m_qsettings->value("hidpi_scale_factor_behavior", "PassThrough").toString(); - + QString result = m_qsettings->value("hidpi_scale_factor_behavior", "").toString(); return QEnumHelper::fromString(result, Qt::HighDpiScaleFactorRoundingPolicy::PassThrough); } diff --git a/app/settings.h b/app/settings.h index 3552155..3a2892f 100644 --- a/app/settings.h +++ b/app/settings.h @@ -25,6 +25,7 @@ public: }; Q_ENUM(MouseWheelBehavior) + // TODO: I want to remove Auto behavior in future. enum WindowSizeBehavior { Auto, Maximized,