From 31303a20c77ad7a47498eb039254cbfb488673b1 Mon Sep 17 00:00:00 2001
From: yyc12345 <yyc12321@outlook.com>
Date: Mon, 6 Jul 2026 20:41:58 +0800
Subject: [PATCH] refactor: set openExternalLinks in ui file instead of cpp
 file

---
 app/aboutdialog.cpp |  9 ---------
 app/aboutdialog.ui  | 30 +++++++++++++++++++++++++-----
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/app/aboutdialog.cpp b/app/aboutdialog.cpp
index 62b8ea1..5912bc5 100644
--- a/app/aboutdialog.cpp
+++ b/app/aboutdialog.cpp
@@ -73,19 +73,10 @@ AboutDialog::AboutDialog(QWidget *parent)
         .arg(tr("Some of them are optional and might not be included with this distribution depending on the build environment."));
 
     ui->m_helpTextEdit->setHtml(HELP_HTML);
-    ui->m_helpTextEdit->setOpenExternalLinks(false);
-
     ui->m_aboutTextEdit->setHtml(ABOUT_HTML);
-    ui->m_aboutTextEdit->setOpenExternalLinks(true);
-
     ui->m_specialThanksTextEdit->setHtml(SPECIAL_THANKS_HTML);
-    ui->m_specialThanksTextEdit->setOpenExternalLinks(true);
-
     ui->m_licenseTextEdit->setHtml(LICENSE_HTML);
-    ui->m_licenseTextEdit->setOpenExternalLinks(false);
-
     ui->m_3rdPartyLibsTextEdit->setHtml(THIRD_PARTY_LIBS_HTML);
-    ui->m_3rdPartyLibsTextEdit->setOpenExternalLinks(true);
 
     connect(ui->m_buttonBox, QOverload<QAbstractButton *>::of(&QDialogButtonBox::clicked), this, [this](QAbstractButton * btn){
         Q_UNUSED(btn)
diff --git a/app/aboutdialog.ui b/app/aboutdialog.ui
index 1a0724d..b0ca08e 100644
--- a/app/aboutdialog.ui
+++ b/app/aboutdialog.ui
@@ -26,7 +26,11 @@
       </attribute>
       <layout class="QVBoxLayout" name="helpTabLayout">
        <item>
-        <widget class="QTextBrowser" name="m_helpTextEdit"/>
+         <widget class="QTextBrowser" name="m_helpTextEdit">
+          <property name="openExternalLinks">
+           <bool>false</bool>
+          </property>
+         </widget>
        </item>
       </layout>
      </widget>
@@ -36,7 +40,11 @@
       </attribute>
       <layout class="QVBoxLayout" name="aboutTabLayout">
        <item>
-        <widget class="QTextBrowser" name="m_aboutTextEdit"/>
+         <widget class="QTextBrowser" name="m_aboutTextEdit">
+          <property name="openExternalLinks">
+           <bool>true</bool>
+          </property>
+         </widget>
        </item>
       </layout>
      </widget>
@@ -46,7 +54,11 @@
       </attribute>
       <layout class="QVBoxLayout" name="specialThanksTabLayout">
        <item>
-        <widget class="QTextBrowser" name="m_specialThanksTextEdit"/>
+         <widget class="QTextBrowser" name="m_specialThanksTextEdit">
+          <property name="openExternalLinks">
+           <bool>true</bool>
+          </property>
+         </widget>
        </item>
       </layout>
      </widget>
@@ -56,7 +68,11 @@
       </attribute>
       <layout class="QVBoxLayout" name="licenseTabLayout">
        <item>
-        <widget class="QTextBrowser" name="m_licenseTextEdit"/>
+         <widget class="QTextBrowser" name="m_licenseTextEdit">
+          <property name="openExternalLinks">
+           <bool>false</bool>
+          </property>
+         </widget>
        </item>
       </layout>
      </widget>
@@ -66,7 +82,11 @@
       </attribute>
       <layout class="QVBoxLayout" name="thirdPartyLibsTabLayout">
        <item>
-        <widget class="QTextBrowser" name="m_3rdPartyLibsTextEdit"/>
+         <widget class="QTextBrowser" name="m_3rdPartyLibsTextEdit">
+          <property name="openExternalLinks">
+           <bool>true</bool>
+          </property>
+         </widget>
        </item>
       </layout>
      </widget>