From 02a818b12c8ea3c6c9f04aa15c483b537854a1d5 Mon Sep 17 00:00:00 2001
From: black-desk <me@black-desk.cn>
Date: Mon, 15 May 2023 11:47:34 +0800
Subject: [PATCH] fix: fix a use-after-free

Signed-off-by: black-desk <me@black-desk.cn>
---
 src/modules/dock/entries.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/modules/dock/entries.cpp b/src/modules/dock/entries.cpp
index 36ab738..938d36f 100644
--- a/src/modules/dock/entries.cpp
+++ b/src/modules/dock/entries.cpp
@@ -61,12 +61,13 @@ void Entries::remove(Entry *entry)
     for (auto iter = m_items.begin(); iter != m_items.end();) {
         if ((*iter)->getId() == entry->getId()) {
             iter = m_items.erase(iter);
-            removeCb(entry);
-            delete entry;
         } else {
             iter++;
         }
     }
+
+    removeCb(entry);
+    delete entry;
 }
 
 void Entries::move(int oldIndex, int newIndex)