From 0555895452f5034e1d3548dc020878a83554610a Mon Sep 17 00:00:00 2001 From: ck Date: Wed, 15 May 2024 09:13:05 +0800 Subject: [PATCH] chore: check std::find_if result sendErrorReply if not found.. --- src/dbus/mimemanager1service.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/dbus/mimemanager1service.cpp b/src/dbus/mimemanager1service.cpp index 8a6eb73..2024981 100644 --- a/src/dbus/mimemanager1service.cpp +++ b/src/dbus/mimemanager1service.cpp @@ -119,6 +119,12 @@ void MimeManager1Service::unsetDefaultApplication(const QStringList &mimeTypes) auto &app = m_infos.front().appsList(); auto userConfig = std::find_if(app.begin(), app.end(), [](const MimeApps &config) { return !config.isDesktopSpecific(); }); + if (userConfig == app.end()) { + qWarning() << "couldn't find user mimeApps"; + sendErrorReply(QDBusError::InternalError); + return; + } + for (const auto &mime : mimeTypes) { userConfig->unsetDefaultApplication(mime); }