refact: apply review suggestions

Signed-off-by: black-desk <me@black-desk.cn>
This commit is contained in:
black-desk
2023-08-11 14:53:05 +08:00
committed by Comix
parent 4394edd8b8
commit 5183716873
10 changed files with 49 additions and 53 deletions

View File

@ -25,17 +25,15 @@ using IconMap = QMap<QString, QMap<uint, QMap<QString, QDBusUnixFileDescriptor>>
inline QString getApplicationLauncherBinary()
{
static bool logFlag{true};
auto value = qgetenv("DEEPIN_APPLICATION_MANAGER_APP_LAUNCH_HELPER_BIN");
if (value.isEmpty()) {
return ApplicationLaunchHelperBinary;
}
if (logFlag) {
static const QString bin = []() -> QString {
auto value = qgetenv("DEEPIN_APPLICATION_MANAGER_APP_LAUNCH_HELPER_BIN");
if (value.isEmpty()) {
return ApplicationLaunchHelperBinary;
}
qWarning() << "Using app launch helper defined in environment variable DEEPIN_APPLICATION_MANAGER_APP_LAUNCH_HELPER_BIN.";
logFlag = false;
}
return value;
return value;
}();
return bin;
}
enum class DBusType { Session = QDBusConnection::SessionBus, System = QDBusConnection::SystemBus, Custom };