From ebe218b70e0b3f1ecddae53c1512d3a74f2d92de Mon Sep 17 00:00:00 2001 From: ComixHe Date: Tue, 5 Sep 2023 14:33:21 +0800 Subject: [PATCH] fix: AM crashed when Launch failed Signed-off-by: ComixHe --- src/dbus/applicationservice.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/dbus/applicationservice.cpp b/src/dbus/applicationservice.cpp index 764a7ea..7226556 100644 --- a/src/dbus/applicationservice.cpp +++ b/src/dbus/applicationservice.cpp @@ -173,10 +173,8 @@ QDBusObjectPath ApplicationService::Launch(const QString &action, const QStringL process.start(m_launcher, commands); process.waitForFinished(); if (auto code = process.exitCode(); code != 0) { - auto msg = QString{"Launch Application Failed"}; - qWarning() << msg; - sendErrorReply(QDBusError::Failed, msg); - return {}; + qWarning() << "Launch Application Failed"; + return QDBusError::Failed; } return objectPath; } @@ -203,10 +201,8 @@ QDBusObjectPath ApplicationService::Launch(const QString &action, const QStringL process.waitForFinished(); auto exitCode = process.exitCode(); if (exitCode != 0) { - auto msg = QString{"Launch Application Failed"}; - qWarning() << msg; - sendErrorReply(QDBusError::Failed, msg); - return {}; + qWarning() << "Launch Application Failed"; + return QDBusError::Failed; } return objectPath; },