upgrade to JUCE 5.4.3. Remove (probably) unused JUCE modules. Remove VST2 target (it's been end-of-life'd by Steinberg and by JUCE)

modules/juce_audio_basics/sources/juce_AudioSource.h

@@ -32,9 +32,7 @@ namespace juce
 struct JUCE_API  AudioSourceChannelInfo
 {
     /** Creates an uninitialised AudioSourceChannelInfo. */
-    AudioSourceChannelInfo() noexcept
-    {
-    }
+    AudioSourceChannelInfo() = default;
 
     /** Creates an AudioSourceChannelInfo. */
     AudioSourceChannelInfo (AudioBuffer<float>* bufferToUse,
@@ -113,11 +111,11 @@ class JUCE_API  AudioSource
 protected:
     //==============================================================================
     /** Creates an AudioSource. */
-    AudioSource() noexcept      {}
+    AudioSource() = default;
 
 public:
     /** Destructor. */
-    virtual ~AudioSource()      {}
+    virtual ~AudioSource()      = default;
 
     //==============================================================================
     /** Tells the source to prepare for playing.

modules/juce_audio_basics/sources/juce_BufferingAudioSource.h

@@ -66,7 +66,7 @@ public:
         The input source may be deleted depending on whether the deleteSourceWhenDeleted
         flag was set in the constructor.
     */
-    ~BufferingAudioSource();
+    ~BufferingAudioSource() override;
 
     //==============================================================================
     /** Implementation of the AudioSource method. */

modules/juce_audio_basics/sources/juce_ChannelRemappingAudioSource.h

@@ -56,7 +56,7 @@ public:
                                  bool deleteSourceWhenDeleted);
 
     /** Destructor. */
-    ~ChannelRemappingAudioSource();
+    ~ChannelRemappingAudioSource() override;
 
     //==============================================================================
     /** Specifies a number of channels that this audio source must produce from its

modules/juce_audio_basics/sources/juce_IIRFilterAudioSource.h

@@ -43,7 +43,7 @@ public:
                           bool deleteInputWhenDeleted);
 
     /** Destructor. */
-    ~IIRFilterAudioSource();
+    ~IIRFilterAudioSource() override;
 
     //==============================================================================
     /** Changes the filter to use the same parameters as the one being passed in. */

modules/juce_audio_basics/sources/juce_MemoryAudioSource.cpp

@@ -49,7 +49,8 @@ void MemoryAudioSource::getNextAudioBlock (const AudioSourceChannelInfo& bufferT
     auto max = 0, pos = 0;
     auto n = buffer.getNumSamples(), m = bufferToFill.numSamples;
 
-    for (auto i = position; (i < n || isLooping) && (pos < m); i += max)
+    int i;
+    for (i = position; (i < n || isLooping) && (pos < m); i += max)
     {
         max = jmin (m - pos, n - (i % n));
 
@@ -65,6 +66,8 @@ void MemoryAudioSource::getNextAudioBlock (const AudioSourceChannelInfo& bufferT
 
     if (pos < m)
         dst.clear (bufferToFill.startSample + pos, m - pos);
+
+    position = (i % n);
 }
 
 } // namespace juce

modules/juce_audio_basics/sources/juce_MixerAudioSource.h

@@ -41,7 +41,7 @@ public:
     MixerAudioSource();
 
     /** Destructor. */
-    ~MixerAudioSource();
+    ~MixerAudioSource() override;
 
     //==============================================================================
     /** Adds an input source to the mixer.

modules/juce_audio_basics/sources/juce_PositionableAudioSource.h

@@ -40,11 +40,11 @@ class JUCE_API  PositionableAudioSource  : public AudioSource
 protected:
     //==============================================================================
     /** Creates the PositionableAudioSource. */
-    PositionableAudioSource() noexcept  {}
+    PositionableAudioSource() = default;
 
 public:
     /** Destructor */
-    ~PositionableAudioSource()          {}
+    ~PositionableAudioSource() override = default;
 
     //==============================================================================
     /** Tells the stream to move to a new position.

modules/juce_audio_basics/sources/juce_ResamplingAudioSource.h

@@ -47,7 +47,7 @@ public:
                            int numChannels = 2);
 
     /** Destructor. */
-    ~ResamplingAudioSource();
+    ~ResamplingAudioSource() override;
 
     /** Changes the resampling ratio.
 

modules/juce_audio_basics/sources/juce_ReverbAudioSource.h

@@ -44,7 +44,7 @@ public:
                        bool deleteInputWhenDeleted);
 
     /** Destructor. */
-    ~ReverbAudioSource();
+    ~ReverbAudioSource() override;
 
     //==============================================================================
     /** Returns the parameters from the reverb. */

modules/juce_audio_basics/sources/juce_ToneGeneratorAudioSource.h

@@ -38,7 +38,7 @@ public:
     ToneGeneratorAudioSource();
 
     /** Destructor. */
-    ~ToneGeneratorAudioSource();
+    ~ToneGeneratorAudioSource() override;
 
     //==============================================================================
     /** Sets the signal's amplitude. */