upgrade to JUCE 5.4.3. Remove (probably) unused JUCE modules. Remove VST2 target (it's been end-of-life'd by Steinberg and by JUCE)

modules/juce_core/text/juce_StringArray.cpp

@@ -33,7 +33,12 @@ StringArray::StringArray (const StringArray& other)
 }
 
 StringArray::StringArray (StringArray&& other) noexcept
-    : strings (static_cast<Array<String>&&> (other.strings))
+    : strings (std::move (other.strings))
+{
+}
+
+StringArray::StringArray (Array<String>&& other) noexcept
+    : strings (std::move (other))
 {
 }
 
@@ -80,7 +85,7 @@ StringArray& StringArray::operator= (const StringArray& other)
 
 StringArray& StringArray::operator= (StringArray&& other) noexcept
 {
-    strings = static_cast<Array<String>&&> (other.strings);
+    strings = std::move (other.strings);
     return *this;
 }
 
@@ -127,19 +132,18 @@ String& StringArray::getReference (int index) noexcept
     return strings.getReference (index);
 }
 
-void StringArray::add (const String& newString)
+void StringArray::add (String newString)
 {
-    strings.add (newString);
+    // NB: the local temp copy is to avoid a dangling pointer if the
+    // argument being passed-in is a reference into this array.
+    strings.add (std::move (newString));
 }
 
-void StringArray::add (String&& stringToAdd)
+void StringArray::insert (int index, String newString)
 {
-    strings.add (static_cast<String&&> (stringToAdd));
-}
-
-void StringArray::insert (int index, const String& newString)
-{
-    strings.insert (index, newString);
+    // NB: the local temp copy is to avoid a dangling pointer if the
+    // argument being passed-in is a reference into this array.
+    strings.insert (index, std::move (newString));
 }
 
 bool StringArray::addIfNotAlreadyThere (const String& newString, bool ignoreCase)
@@ -153,6 +157,8 @@ bool StringArray::addIfNotAlreadyThere (const String& newString, bool ignoreCase
 
 void StringArray::addArray (const StringArray& otherArray, int startIndex, int numElementsToAdd)
 {
+    jassert (this != &otherArray); // can't add from our own elements!
+
     if (startIndex < 0)
     {
         jassertfalse;
@@ -168,13 +174,15 @@ void StringArray::addArray (const StringArray& otherArray, int startIndex, int n
 
 void StringArray::mergeArray (const StringArray& otherArray, bool ignoreCase)
 {
+    jassert (this != &otherArray); // can't add from our own elements!
+
     for (auto& s : otherArray)
         addIfNotAlreadyThere (s, ignoreCase);
 }
 
-void StringArray::set (int index, const String& newString)
+void StringArray::set (int index, String newString)
 {
-    strings.set (index, newString);
+    strings.set (index, std::move (newString));
 }
 
 bool StringArray::contains (StringRef stringToLookFor, bool ignoreCase) const