upgrade to JUCE 5.4.3. Remove (probably) unused JUCE modules. Remove VST2 target (it's been end-of-life'd by Steinberg and by JUCE)

modules/juce_gui_extra/code_editor/juce_CPlusPlusCodeTokeniser.h

@@ -40,7 +40,7 @@ class JUCE_API  CPlusPlusCodeTokeniser    : public CodeTokeniser
 public:
     //==============================================================================
     CPlusPlusCodeTokeniser();
-    ~CPlusPlusCodeTokeniser();
+    ~CPlusPlusCodeTokeniser() override;
 
     //==============================================================================
     int readNextToken (CodeDocument::Iterator&) override;

modules/juce_gui_extra/code_editor/juce_CPlusPlusCodeTokeniserFunctions.h

@@ -101,7 +101,7 @@ struct CppTokeniserFunctions
                 break;
         }
 
-        for (int i = 0; k[i] != 0; ++i)
+        for (int i = 0; k[i] != nullptr; ++i)
             if (token.compare (CharPointer_ASCII (k[i])) == 0)
                 return true;
 

modules/juce_gui_extra/code_editor/juce_CodeDocument.cpp

@@ -755,8 +755,8 @@ void CodeDocument::checkLastLineStatus()
 }
 
 //==============================================================================
-void CodeDocument::addListener    (CodeDocument::Listener* l) noexcept   { listeners.add (l); }
-void CodeDocument::removeListener (CodeDocument::Listener* l) noexcept   { listeners.remove (l); }
+void CodeDocument::addListener    (CodeDocument::Listener* l)   { listeners.add (l); }
+void CodeDocument::removeListener (CodeDocument::Listener* l)   { listeners.remove (l); }
 
 //==============================================================================
 struct CodeDocument::InsertAction   : public UndoableAction

modules/juce_gui_extra/code_editor/juce_CodeDocument.h

@@ -326,8 +326,8 @@ public:
     class JUCE_API  Listener
     {
     public:
-        Listener() {}
-        virtual ~Listener() {}
+        Listener() = default;
+        virtual ~Listener() = default;
 
         /** Called by a CodeDocument when text is added. */
         virtual void codeDocumentTextInserted (const String& newText, int insertIndex) = 0;
@@ -340,12 +340,12 @@ public:
         If the listener is already registered, this method has no effect.
         @see removeListener
     */
-    void addListener (Listener* listener) noexcept;
+    void addListener (Listener* listener);
 
     /** Deregisters a listener.
         @see addListener
     */
-    void removeListener (Listener* listener) noexcept;
+    void removeListener (Listener* listener);
 
     //==============================================================================
     /** Iterates the text in a CodeDocument.

modules/juce_gui_extra/code_editor/juce_CodeEditorComponent.h

@@ -57,7 +57,7 @@ public:
                          CodeTokeniser* codeTokeniser);
 
     /** Destructor. */
-    ~CodeEditorComponent();
+    ~CodeEditorComponent() override;
 
     //==============================================================================
     /** Returns the code document that this component is editing. */
@@ -382,13 +382,9 @@ private:
     ApplicationCommandManager* appCommandManager = nullptr;
 
     class Pimpl;
-    friend class Pimpl;
-    friend struct ContainerDeletePolicy<Pimpl>;
     std::unique_ptr<Pimpl> pimpl;
 
     class GutterComponent;
-    friend class GutterComponent;
-    friend struct ContainerDeletePolicy<GutterComponent>;
     std::unique_ptr<GutterComponent> gutter;
 
     enum DragType

modules/juce_gui_extra/code_editor/juce_CodeTokeniser.h

@@ -39,8 +39,8 @@ namespace juce
 class JUCE_API  CodeTokeniser
 {
 public:
-    CodeTokeniser()                 {}
-    virtual ~CodeTokeniser()        {}
+    CodeTokeniser() = default;
+    virtual ~CodeTokeniser() = default;
 
     //==============================================================================
     /** Reads the next token from the source and returns its token type.

modules/juce_gui_extra/code_editor/juce_LuaCodeTokeniser.cpp

@@ -68,7 +68,7 @@ struct LuaTokeniserFunctions
                 break;
         }
 
-        for (int i = 0; k[i] != 0; ++i)
+        for (int i = 0; k[i] != nullptr; ++i)
             if (token.compare (CharPointer_ASCII (k[i])) == 0)
                 return true;
 

modules/juce_gui_extra/code_editor/juce_LuaCodeTokeniser.h

@@ -37,7 +37,7 @@ class JUCE_API  LuaTokeniser   : public CodeTokeniser
 public:
     //==============================================================================
     LuaTokeniser();
-    ~LuaTokeniser();
+    ~LuaTokeniser() override;
 
     //==============================================================================
     int readNextToken (CodeDocument::Iterator&) override;

modules/juce_gui_extra/code_editor/juce_XMLCodeTokeniser.h

@@ -37,7 +37,7 @@ class JUCE_API  XmlTokeniser   : public CodeTokeniser
 public:
     //==============================================================================
     XmlTokeniser();
-    ~XmlTokeniser();
+    ~XmlTokeniser() override;
 
     //==============================================================================
     int readNextToken (CodeDocument::Iterator&) override;