upgrade to JUCE 5.4.3. Remove (probably) unused JUCE modules. Remove VST2 target (it's been end-of-life'd by Steinberg and by JUCE)

modules/juce_gui_extra/embedding/juce_ActiveXControlComponent.h

@@ -118,7 +118,6 @@ public:
 
 private:
     class Pimpl;
-    friend struct ContainerDeletePolicy<Pimpl>;
     std::unique_ptr<Pimpl> control;
     bool mouseEventsAllowed = true;
 

modules/juce_gui_extra/embedding/juce_AndroidViewComponent.h

@@ -46,12 +46,8 @@ class JUCE_API  AndroidViewComponent   : public Component
 {
 public:
     //==============================================================================
-    /** Create an initially-empty container. The optional flag should be left as
-        false in most of the cases. Currently it is only set to true as a workaround
-        for a web browser bug, where scrolling would be very slow and it would
-        randomly scroll in an opposite direction of scrolling.
-     */
-    AndroidViewComponent (bool embedAsSiblingRatherThanChild = false);
+    /** Create an initially-empty container */
+    AndroidViewComponent();
 
     /** Destructor. */
     ~AndroidViewComponent();
@@ -77,8 +73,6 @@ private:
     class Pimpl;
     std::unique_ptr<Pimpl> pimpl;
 
-    bool embedAsSiblingRatherThanChild;
-
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (AndroidViewComponent)
 };
 

modules/juce_gui_extra/embedding/juce_NSViewComponent.h

@@ -50,21 +50,21 @@ public:
     NSViewComponent();
 
     /** Destructor. */
-    ~NSViewComponent();
+    ~NSViewComponent() override;
 
     /** Assigns an NSView to this peer.
 
         The view will be retained and released by this component for as long as
         it is needed. To remove the current view, just call setView (nullptr).
 
-        Note: a void* is used here to avoid including the cocoa headers as
+        Note: A void* is used here to avoid including the cocoa headers as
         part of the juce.h, but the method expects an NSView*.
     */
     void setView (void* nsView);
 
     /** Returns the current NSView.
 
-        Note: a void* is returned here to avoid the needing to include the cocoa
+        Note: A void* is returned here to avoid the needing to include the cocoa
         headers, so you should just cast the return value to an NSView*.
     */
     void* getView() const;

modules/juce_gui_extra/embedding/juce_ScopedDPIAwarenessDisabler.h

@@ -0,0 +1,56 @@
+/*
+  ==============================================================================
+
+   This file is part of the JUCE library.
+   Copyright (c) 2017 - ROLI Ltd.
+
+   JUCE is an open source library subject to commercial or open-source
+   licensing.
+
+   By using JUCE, you agree to the terms of both the JUCE 5 End-User License
+   Agreement and JUCE 5 Privacy Policy (both updated and effective as of the
+   27th April 2017).
+
+   End User License Agreement: www.juce.com/juce-5-licence
+   Privacy Policy: www.juce.com/juce-5-privacy-policy
+
+   Or: You may also use this code under the terms of the GPL v3 (see
+   www.gnu.org/licenses).
+
+   JUCE IS PROVIDED "AS IS" WITHOUT ANY WARRANTY, AND ALL WARRANTIES, WHETHER
+   EXPRESSED OR IMPLIED, INCLUDING MERCHANTABILITY AND FITNESS FOR PURPOSE, ARE
+   DISCLAIMED.
+
+  ==============================================================================
+*/
+
+namespace juce
+{
+
+#if (JUCE_WINDOWS && JUCE_WIN_PER_MONITOR_DPI_AWARE) || DOXYGEN
+
+//==============================================================================
+/**
+    A Windows-specific class that temporarily sets the DPI awareness context of
+    the current thread to be DPI unaware and resets it to the previous context
+    when it goes out of scope.
+
+    If you create one of these before creating a top-level window, the window
+    will be DPI unaware and bitmap strectched by the OS on a display with >100%
+    scaling.
+
+    You shouldn't use this unless you really know what you are doing and
+    are dealing with native HWNDs.
+*/
+class JUCE_API  ScopedDPIAwarenessDisabler
+{
+public:
+    ScopedDPIAwarenessDisabler();
+    ~ScopedDPIAwarenessDisabler();
+
+private:
+    void* previousContext = nullptr;
+};
+#endif
+
+} // namespace juce

modules/juce_gui_extra/embedding/juce_UIViewComponent.h

@@ -57,14 +57,14 @@ public:
         The view will be retained and released by this component for as long as
         it is needed. To remove the current view, just call setView (nullptr).
 
-        Note: a void* is used here to avoid including the cocoa headers as
+        Note: A void* is used here to avoid including the cocoa headers as
         part of the juce.h, but the method expects an UIView*.
     */
     void setView (void* uiView);
 
     /** Returns the current UIView.
 
-        Note: a void* is returned here to avoid the needing to include the cocoa
+        Note: A void* is returned here to avoid the needing to include the cocoa
         headers, so you should just cast the return value to an UIView*.
     */
     void* getView() const;
@@ -80,7 +80,6 @@ public:
 
 private:
     class Pimpl;
-    friend class Pimpl;
     std::unique_ptr<Pimpl> pimpl;
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (UIViewComponent)

modules/juce_gui_extra/embedding/juce_XEmbedComponent.h

@@ -107,7 +107,6 @@ private:
     friend unsigned long juce_getCurrentFocusWindow (ComponentPeer*);
 
     class Pimpl;
-    friend struct ContainerDeletePolicy<Pimpl>;
     std::unique_ptr<Pimpl> pimpl;
 };