From 7c79abc9c77b8b5ada8133299386d8aacfb36774 Mon Sep 17 00:00:00 2001 From: Gary Wang Date: Sun, 1 Feb 2026 19:37:46 +0800 Subject: [PATCH] tidy signal handling --- main.cpp | 2 +- tabwidget.cpp | 12 ------------ tabwidget.h | 1 - 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/main.cpp b/main.cpp index bd93107..cdbbcae 100644 --- a/main.cpp +++ b/main.cpp @@ -18,7 +18,7 @@ int main(int argc, char *argv[]) KLocalizedString::setApplicationDomain(QByteArrayLiteral("pineapple-notepad")); KAboutData aboutData(QStringLiteral("pineapple-notepad"), - "Pineapple Notepad(迫真)", + "Pineapple Notepad", QStringLiteral("0.1"), "A Scintilla-based Text Editor", KAboutLicense::Unknown, diff --git a/tabwidget.cpp b/tabwidget.cpp index 723e9b5..e845d9e 100644 --- a/tabwidget.cpp +++ b/tabwidget.cpp @@ -70,9 +70,6 @@ int TabWidget::openDocument(const QString &filePath) SciEdit *editor = createEditor(); m_editors[docId] = editor; - // 临时断开信号连接,避免setText触发textChanged导致文档被标记为已修改 - disconnectEditorSignals(editor); - // 设置编辑器内容 QString content = m_documentManager->getDocumentContent(docId); const QByteArray contentBytes = content.toUtf8(); @@ -243,7 +240,6 @@ bool TabWidget::closeTab(int index) // 清理编辑器和文档 if (m_editors.contains(docId)) { SciEdit *editor = m_editors[docId]; - disconnectEditorSignals(editor); m_editors.remove(docId); } @@ -435,11 +431,3 @@ void TabWidget::connectEditorSignals(SciEdit *editor) connect(editor, &ScintillaEditBase::savePointChanged, this, &TabWidget::onEditorSavePointChanged); } } - -void TabWidget::disconnectEditorSignals(SciEdit *editor) -{ - if (editor) { - disconnect(editor, &SciEdit::textChanged, this, &TabWidget::onEditorTextChanged); - disconnect(editor, &ScintillaEditBase::savePointChanged, this, &TabWidget::onEditorSavePointChanged); - } -} diff --git a/tabwidget.h b/tabwidget.h index 864733b..4602d97 100644 --- a/tabwidget.h +++ b/tabwidget.h @@ -54,5 +54,4 @@ private: SciEdit *createEditor(); void updateTabTitle(int tabIndex); void connectEditorSignals(SciEdit *editor); - void disconnectEditorSignals(SciEdit *editor); };