removing redundant framebuffer virtual methods

include/blah/graphics/framebuffer.h

@@ -54,16 +54,16 @@ namespace Blah
 		virtual const Attachments& attachments() const = 0;
 
 		// Gets the Attachment at a given index from the FrameBuffer
-		virtual TextureRef& attachment(int index) = 0;
+		TextureRef& attachment(int index);
 
 		// Gets the Attachment at a given index from the FrameBuffer
-		virtual const TextureRef& attachment(int index) const = 0;
+		const TextureRef& attachment(int index) const;
 
 		// Gets the width of the FrameBuffer
-		virtual int width() const = 0;
+		virtual int width() const;
 
 		// Gets the height of the FrameBuffer
-		virtual int height() const = 0;
+		virtual int height() const;
 
 		// Clears the FrameBuffer
 		virtual void clear(Color color = Color::black, float depth = 1.0f, u8 stencil = 0, ClearMask mask = ClearMask::All) = 0;

src/core/app.cpp

@@ -278,18 +278,6 @@ namespace
 			return empty_attachments;
 		}
 
-		virtual TextureRef& attachment(int index) override
-		{
-			BLAH_ASSERT(false, "Backbuffer doesn't have any attachments");
-			return empty_texture;
-		}
-
-		virtual const TextureRef& attachment(int index) const override
-		{
-			BLAH_ASSERT(false, "Backbuffer doesn't have any attachments");
-			return empty_texture;
-		}
-
 		virtual int width() const override
 		{
 			return App::draw_width();

src/graphics/batch.cpp

@@ -1090,4 +1090,4 @@ void Batch::str(const SpriteFont& font, const String& text, const Vec2& pos, Tex
 	}
 
 	pop_matrix();
-}
+}

src/graphics/blend.cpp

@@ -22,4 +22,4 @@ const BlendMode BlendMode::Subtract = BlendMode(
 	BlendFactor::One,
 	BlendMask::RGBA,
 	0xffffffff
-);
+);

src/graphics/framebuffer.cpp

@@ -31,3 +31,23 @@ FrameBufferRef FrameBuffer::create(int width, int height, const AttachmentFormat
 
 	return GraphicsBackend::create_framebuffer(width, height, attachments.data(), attachments.size());
 }
+
+TextureRef& FrameBuffer::attachment(int index)
+{
+	return attachments()[index];
+}
+
+const TextureRef& FrameBuffer::attachment(int index) const
+{
+	return attachments()[index];
+}
+
+int FrameBuffer::width() const
+{
+	return attachments()[0]->width();
+}
+
+int FrameBuffer::height() const
+{
+	return attachments()[0]->height();
+}

src/graphics/mesh.cpp

@@ -38,4 +38,4 @@ VertexFormat::VertexFormat(std::initializer_list<VertexAttribute> attributes, in
 	}
 
 	this->stride = stride;
-}
+}

src/graphics/renderpass.cpp

@@ -91,4 +91,4 @@ void RenderPass::perform()
 
 	// perform render
 	GraphicsBackend::render(pass);
-}
+}

src/graphics/shader.cpp

@@ -36,4 +36,4 @@ ShaderRef Shader::create(const ShaderData& data)
 	}
 
 	return shader;
-}
+}

src/graphics/spritefont.cpp

@@ -296,4 +296,4 @@ const SpriteFont::Character& SpriteFont::operator[](Codepoint codepoint) const
 	if (it != m_characters.end())
 		return it->second;
 	return empty;
-}
+}

src/graphics/subtexture.cpp

@@ -61,4 +61,4 @@ Subtexture Subtexture::crop(const Rect& clip) const
 	crop_info(clip, &dst.source, &dst.frame);
 	dst.update();
 	return dst;
-}
+}

src/graphics/texture.cpp

@@ -32,4 +32,4 @@ TextureRef Texture::create(Stream& stream)
 TextureRef Texture::create(const FilePath& file)
 {
 	return create(Image(file));
-}
+}

src/internal/graphics_backend_d3d11.cpp

@@ -332,26 +332,6 @@ namespace Blah
 			return m_attachments;
 		}
 
-		virtual TextureRef& attachment(int index) override
-		{
-			return m_attachments[index];
-		}
-
-		virtual const TextureRef& attachment(int index) const override
-		{
-			return m_attachments[index];
-		}
-
-		virtual int width() const override
-		{
-			return m_attachments[0]->width();
-		}
-
-		virtual int height() const override
-		{
-			return m_attachments[0]->height();
-		}
-
 		virtual void clear(Color color, float depth, u8 stencil, ClearMask mask) override
 		{
 			float col[4] = { color.r / 255.0f, color.g / 255.0f, color.b / 255.0f, color.a / 255.0f };

src/internal/graphics_backend_dummy.cpp

@@ -83,26 +83,6 @@ namespace Blah
 			return m_attachments;
 		}
 
-		virtual TextureRef& attachment(int index) override
-		{
-			return m_attachments[index];
-		}
-
-		virtual const TextureRef& attachment(int index) const override
-		{
-			return m_attachments[index];
-		}
-
-		virtual int width() const override
-		{
-			return m_attachments[0]->width();
-		}
-
-		virtual int height() const override
-		{
-			return m_attachments[0]->height();
-		}
-
 		virtual void clear(Color color) override
 		{
 

src/internal/graphics_backend_gl.cpp

@@ -729,26 +729,6 @@ namespace Blah
 			return m_attachments;
 		}
 
-		virtual TextureRef& attachment(int index) override
-		{
-			return m_attachments[index];
-		}
-
-		virtual const TextureRef& attachment(int index) const override
-		{
-			return m_attachments[index];
-		}
-
-		virtual int width() const override
-		{
-			return m_width;
-		}
-
-		virtual int height() const override
-		{
-			return m_height;
-		}
-
 		virtual void clear(Color color, float depth, u8 stencil, ClearMask mask) override
 		{
 			int clear = 0;