yyc12345/YKanBan
1
0 Fork 0
Code Activity

fix(search): cap an expression at 256 atoms

Browse Source 
The compiled SQL chains every atom into one expression, and SQLite rejects
expressions deeper than 1000 levels. A query of about 1000 words parsed but
then failed in SQL, outside the syntax-error handling, and crashed the app.
The parser now rejects more than 256 atoms as a syntax error.
This commit is contained in:
doyaGu committed 2026-10-03 08:49:57 -04:00
1 parent 1d744ba504
commit 23f7806e2d
5 files changed
+79 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

YKanBan.Tests/Search/SearchSqlCompilerTests.cs
+16
View File
@@ -190,4 +190,20 @@ public class SearchSqlCompilerTests
CollectionAssert.AreEqual(new[] { 5L }, fixture.Search("tag:äpfel"));
CollectionAssert.AreEqual(new[] { 5L }, fixture.Search("column:érable"));
}
[TestMethod]
public void LargestAcceptedQueriesRunWithinTheSqliteExpressionDepth()
{
using var fixture = new SearchFixture();
int count = SearchQueryParser.MaxAtomCount;
int depth = SearchQueryParser.MaxNestingDepth;
string nested = string.Concat(Enumerable.Repeat("(tag:x OR ", depth))
+ string.Join(" ", Enumerable.Repeat("apple", count - depth))
+ new string(')', depth);
CollectionAssert.AreEqual(new[] { 2L }, fixture.Search(string.Join(" ", Enumerable.Repeat("apple", count))));
CollectionAssert.AreEqual(new[] { 2L }, fixture.Search(string.Join(" OR ", Enumerable.Repeat("apple", count))));
CollectionAssert.AreEqual(new[] { 2L }, fixture.Search(string.Join(" ", Enumerable.Repeat("title:apple", count))));
CollectionAssert.AreEqual(new[] { 2L }, fixture.Search(nested));
}
}