yyc12345/YYCCommonplace
1
0
Fork 0
Code Activity

fix: fix binstore bugs according to test

Browse Source
This commit is contained in:
yyc12345
2025-12-16 14:37:46 +08:00
parent fcd0b3364f
commit 194f055039
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/yycc/carton/binstore/storage.hpp
View File

@@ -181,6 +181,9 @@ namespace yycc::carton::binstore::storage {
auto ba = success_ser ? std::move(rv_ser.value()) : serdes.reset(); auto ba = success_ser ? std::move(rv_ser.value()) : serdes.reset();
// Assign it to setting's raw value. // Assign it to setting's raw value.
this->set_raw_value(token, std::move(ba)); this->set_raw_value(token, std::move(ba));
// Return result
return success_ser;
} }
}; };

4
test/yycc/carton/binstore.cpp
View File

@@ -265,7 +265,7 @@ namespace yycctest::carton::binstore {
protected: protected:
CartonBinstoreVersion() { CartonBinstoreVersion() {
// Create settings // Create settings
auto settings = SettingCollection(); settings = SettingCollection();
setting = settings.add_setting(Setting(u8"int-setting")); setting = settings.add_setting(Setting(u8"int-setting"));
} }
~CartonBinstoreVersion() override = default; ~CartonBinstoreVersion() override = default;
@@ -302,7 +302,7 @@ namespace yycctest::carton::binstore {
TEST_F(CartonBinstoreVersion, LoadStrategy) { TEST_F(CartonBinstoreVersion, LoadStrategy) {
// Prepare buffer and essential settings // Prepare buffer and essential settings
constexpr VersionIdentifier OLD_VERSION = 32; constexpr VersionIdentifier OLD_VERSION = 16;
constexpr VersionIdentifier MID_VERSION = 32; constexpr VersionIdentifier MID_VERSION = 32;
constexpr VersionIdentifier NEW_VERSION = 61; constexpr VersionIdentifier NEW_VERSION = 61;