yyc12345/stb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stb_vorbis: Fix memory leak in stb_vorbis

Browse Source 
When start_decoder() fails it may already have allocated memory
for .vendor and/or .comment_list. Call vorbis_deinit() to free
any allocated memory.

Fixes issue #1051.
This commit is contained in:
morlad (iLeitgeb) 2021-03-12 14:30:06 +00:00 committed by Fabian Giesen
parent 2e3a6e8222
commit 6fe053614c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
stb_vorbis.c
View File

@ -33,7 +33,7 @@
// Timur Gagiev Maxwell Koo Peter Waller // Timur Gagiev Maxwell Koo Peter Waller
// github:audinowho Dougall Johnson David Reid // github:audinowho Dougall Johnson David Reid
// github:Clownacy Pedro J. Estebanez Remi Verschelde // github:Clownacy Pedro J. Estebanez Remi Verschelde
// AnthoFoxo // AnthoFoxo github:morlat
// //
// Partial history: // Partial history:
// 1.21 - 2021-07-02 - fix bug for files with no comments // 1.21 - 2021-07-02 - fix bug for files with no comments
@ -4513,6 +4513,7 @@ stb_vorbis *stb_vorbis_open_pushdata(
*error = VORBIS_need_more_data; *error = VORBIS_need_more_data;
else else
*error = p.error; *error = p.error;
vorbis_deinit(&p);
return NULL; return NULL;
} }
f = vorbis_alloc(&p); f = vorbis_alloc(&p);