blumia/dde-application-manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: fix a use-after-free

Browse Source 
Signed-off-by: black-desk <me@black-desk.cn>
This commit is contained in:
black-desk 2023-05-15 11:47:34 +08:00 committed by deepin-bot[bot]
parent e3fdb67864
commit 02a818b12c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/dock/entries.cpp
View File

@ -61,12 +61,13 @@ void Entries::remove(Entry *entry)
for (auto iter = m_items.begin(); iter != m_items.end();) { for (auto iter = m_items.begin(); iter != m_items.end();) {
if ((*iter)->getId() == entry->getId()) { if ((*iter)->getId() == entry->getId()) {
iter = m_items.erase(iter); iter = m_items.erase(iter);
removeCb(entry);
delete entry;
} else { } else {
iter++; iter++;
} }
} }
removeCb(entry);
delete entry;
} }
void Entries::move(int oldIndex, int newIndex) void Entries::move(int oldIndex, int newIndex)