fix: fix a use-after-free

Signed-off-by: black-desk <me@black-desk.cn>
2023-05-15 11:47:34 +08:00
parent e3fdb67864
commit 02a818b12c
1 changed files with 3 additions and 2 deletions
--- a/src/modules/dock/entries.cpp
+++ b/src/modules/dock/entries.cpp
@ -61,12 +61,13 @@ void Entries::remove(Entry *entry)
    for (auto iter = m_items.begin(); iter != m_items.end();) {
        if ((*iter)->getId() == entry->getId()) {
            iter = m_items.erase(iter);
-            removeCb(entry);
-            delete entry;
        } else {
            iter++;
        }
    }
+
+    removeCb(entry);
+    delete entry;
 }

 void Entries::move(int oldIndex, int newIndex)