mirror/blah
1
0
Fork 0
mirror of https://github.com/NoelFB/blah.git synced 2024-11-25 16:18:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed D3D11 bug where uniform buffer wasn't aligning to 16-byte boundary

Browse Source 
see: https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-packing-rules
This commit is contained in:
Noel Berry 2022-06-21 14:26:39 -07:00 committed by GitHub
parent ee4a2c4e7f
commit e93da13b4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/internal/renderer_d3d11.cpp
View File

@ -1326,6 +1326,14 @@ namespace Blah
if (it.buffer_index == i && ((int)it.shader & (int)type) != 0)
{
// HLSL uniforms can not pass 16-byte (4-float) boundaries, therefore potentially add padding to the buffer so we align to 16 bytes
// For example, if we have filled in 6 floats, our remaining space will be 2. If the next value is larger than 2 floats, we will
// need to move to the next 16-byte (4-float) boundary (in this case 2 floats to begin at 8 floats).
// see: https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-packing-rules
int remaining = 4 - values[i].size() % 4;
if (remaining != 4 && remaining + length > 4)
values[i].expand(remaining);
auto start = values[i].expand(length);
memcpy(start, data, sizeof(float) * length);
}